Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do more error wrapping when creating contacts and URNs #396

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

rowanseymour
Copy link
Member

So we can see where the context canceled errors are coming from

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #396 (db8727b) into main (3163cff) will increase coverage by 0.00%.
The diff coverage is 6.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   71.70%   71.71%           
=======================================
  Files          95       95           
  Lines        8257     8256    -1     
=======================================
  Hits         5921     5921           
+ Misses       1747     1746    -1     
  Partials      589      589           
Impacted Files Coverage Δ
backends/rapidpro/contact.go 46.75% <0.00%> (+0.59%) ⬆️
backends/rapidpro/msg.go 68.39% <0.00%> (ø)
backends/rapidpro/urn.go 72.32% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3163cff...db8727b. Read the comment docs.

@rowanseymour rowanseymour merged commit 56b2beb into main Jan 10, 2022
@rowanseymour rowanseymour deleted the extra_errors branch January 10, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants