http: fix ClientRequest unhandled errors

ClientRequest could someone cause an unhandled error
from socket.

Fixes: nodejs#36931

lib/_http_agent.js

@@ -57,6 +57,8 @@ const {
 const { once } = require('internal/util');
 const { validateNumber, validateOneOf } = require('internal/validators');
 
+function nop() {}
+
 const kOnKeylog = Symbol('onkeylog');
 const kRequestOptions = Symbol('requestOptions');
 const kRequestAsyncResource = Symbol('requestAsyncResource');
@@ -131,7 +133,7 @@ function Agent(options) {
     // and could cause unhandled exception.
 
     if (!socket.writable) {
-      socket.destroy();
+      socket.on('error', nop).destroy();
       return;
     }
 
@@ -159,7 +161,7 @@ function Agent(options) {
     // the freeSockets pool, but only if we're allowed to do so.
     const req = socket._httpMessage;
     if (!req || !req.shouldKeepAlive || !this.keepAlive) {
-      socket.destroy();
+      socket.on('error', nop).destroy();
       return;
     }
 
@@ -173,7 +175,7 @@ function Agent(options) {
         count > this.maxSockets ||
         freeLen >= this.maxFreeSockets ||
         !this.keepSocketAlive(socket)) {
-      socket.destroy();
+      socket.on('error', nop).destroy();
       return;
     }
 

lib/_http_client.js

@@ -801,7 +801,7 @@ function onSocketNT(req, socket, err) {
       req.emit('close');
     }
 
-    if (!err && req.agent) {
+    if (!err && req.agent && !socket.destroyed) {
       socket?.emit('free');
     } else if (socket) {
       finished(socket.destroy(err || req[kError]), (er) => {

test/parallel/test-http-client-abort3.js

@@ -0,0 +1,12 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const http = require('http');
+
+const req = http.get('http://[2604:1380:45f1:3f00::1]:4002');
+
+req.on('error', common.mustCall((err) => {
+  assert.strictEqual(err.code, 'EHOSTUNREACH');
+}));
+req.abort();