Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The macro FSL_FEATURE_FLEXCAN_HAS_ERRATA_8341 is not defined. #225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Masmiseim36
Copy link
Contributor

The macro FSL_FEATURE_FLEXCAN_HAS_ERRATA_8341 is not defined. This means that the code activated by this macro can never be used. Can it therefore be removed?

Discussion: The errata is actually valid for various Kinetis controllers. Shouldn't it therefore be set in the associated feature files? On the other hand, the code of the errata is apparently not needed if it is not active anyway.

Prerequisites

  • I have checked latest main branch and the issue still exists.
  • I did not see it is stated as known-issue in release notes.
  • No similar GitHub issue is related to this change.
  • My code follows the commit guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

Describe the pull request

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  • Test configuration (please complete the following information):
    • Hardware setting:
    • Toolchain:
    • Test Tool preparation:
    • Any other dependencies:
  • Test executed
    Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
    • Build Test
    • Run Test

…ans that the code activated by this macro can never be used. Can it therefore be removed?

Discussion: The errata is actually valid for various Kinetis controllers. Shouldn't it therefore be set in the associated feature files? On the other hand, the code of the errata is apparently not needed if it is not active anyway.
@william-tang914
Copy link

Hi, FSL_FEATURE_FLEXCAN_HAS_ERRATA_8341 will be defined in later new product. It's coming soon.

@Masmiseim36
Copy link
Contributor Author

Hi, FSL_FEATURE_FLEXCAN_HAS_ERRATA_8341 will be defined in later new product. It's coming soon.

Hello @william-tang914 ,

thanks for the feedback.
Errata 8341 is only present in older Kinetis controllers as far as I know. The problem has been fixed in the iMXRT family.
Shouldn't it then also be activated for the existing controllers?

@william-tang914
Copy link

william-tang914 commented Dec 31, 2024

I will double check whether Errata 8341 is applicable to Kinetis controllers which are supported by repo.
Thank you for your advice.

@Masmiseim36
Copy link
Contributor Author

I will double check whether Errata 8341 is applicable to Kinetis controllers which are supported by repo. Thank you for your advice.

It is at least applicable in the Kinetis KV-Family. From the Errata of the KV5x:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants