Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Delete references to CMSIS pack from the cmake files #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmahadevan108
Copy link
Contributor

CMSIS is no longer part of the SDK Git repo

CMSIS is no longer part of the SDK Git repo

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mcuxsusan
Copy link
Contributor

Hi @mmahadevan108, directly remove the cmsis dependency in device_CMSIS.make could result build failure for projects include this device_CMSIS.cmake to get the NXP cmsis files, will see how to resolve the issue.

@mmahadevan108
Copy link
Contributor Author

Should we delete device_CMSIS.cmake since we do not include CMSIS in the SDK github and move this cmake to the CMSIS github repo we fork?

@mcuxsusan
Copy link
Contributor

Hi @mmahadevan108, instead of deleting the device_CMSIS.cmake, I am thinking that maybe I could change the include(CMSIS_Include_core_cm) to include(CMSIS_Include_core_cm OPTIONAL) so that NO issue will be popped out if users like zephyr are not using our cmsis module, what do you see?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants