Skip to content

Commit

Permalink
Prepare v0.1.1
Browse files Browse the repository at this point in the history
  • Loading branch information
nx10 committed Mar 23, 2024
1 parent 1f6352c commit ce1486e
Show file tree
Hide file tree
Showing 4 changed files with 103 additions and 69 deletions.
95 changes: 95 additions & 0 deletions .github/workflows/rhub.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
# R-hub's generic GitHub Actions workflow file. It's canonical location is at
# https://github.com/r-hub/rhub2/blob/v1/inst/workflow/rhub.yaml
# You can update this file to a newer version using the rhub2 package:
#
# rhub2::rhub_setup()
#
# It is unlikely that you need to modify this file manually.

name: R-hub
run-name: "${{ github.event.inputs.id }}: ${{ github.event.inputs.name || format('Manually run by {0}', github.triggering_actor) }}"

on:
workflow_dispatch:
inputs:
config:
description: 'A comma separated list of R-hub platforms to use.'
type: string
default: 'linux,windows,macos'
name:
description: 'Run name. You can leave this empty now.'
type: string
id:
description: 'Unique ID. You can leave this empty now.'
type: string

jobs:

setup:
runs-on: ubuntu-latest
outputs:
containers: ${{ steps.rhub-setup.outputs.containers }}
platforms: ${{ steps.rhub-setup.outputs.platforms }}

steps:
# NO NEED TO CHECKOUT HERE
- uses: r-hub/rhub2/actions/rhub-setup@v1
with:
config: ${{ github.event.inputs.config }}
id: rhub-setup

linux-containers:
needs: setup
if: ${{ needs.setup.outputs.containers != '[]' }}
runs-on: ubuntu-latest
name: ${{ matrix.config.label }}
strategy:
fail-fast: false
matrix:
config: ${{ fromJson(needs.setup.outputs.containers) }}
container:
image: ${{ matrix.config.container }}

steps:
- uses: r-hub/rhub2/actions/rhub-checkout@v1
- uses: r-hub/rhub2/actions/rhub-platform-info@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/rhub2/actions/rhub-setup-deps@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/rhub2/actions/rhub-run-check@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}

other-platforms:
needs: setup
if: ${{ needs.setup.outputs.platforms != '[]' }}
runs-on: ${{ matrix.config.os }}
name: ${{ matrix.config.label }}
strategy:
fail-fast: false
matrix:
config: ${{ fromJson(needs.setup.outputs.platforms) }}

steps:
- uses: r-hub/rhub2/actions/rhub-checkout@v1
- uses: r-hub/rhub2/actions/rhub-setup-r@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
- uses: r-hub/rhub2/actions/rhub-platform-info@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/rhub2/actions/rhub-setup-deps@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
- uses: r-hub/rhub2/actions/rhub-run-check@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: unigd
Type: Package
Title: Universal Graphics Device
Version: 0.1.0
Version: 0.1.1
Authors@R:
c(
person(given = "Florian", family = "Rupprecht", email = "[email protected]", role = c("aut", "cre"), comment = c(ORCID = "0000-0002-1795-8624")),
Expand Down
7 changes: 6 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# unigd 0.1.0.9000
# unigd 0.1.1

- Fix issues with 'libtiff'. (Thanks @benz0li)
- Update linking on Windows for upcoming version of 'Rtools'. (Thanks @kalibera)

# unigd 0.1.0

- Split graphics rendering and R interface from 'httpgd'.
- Large refactoring and rewrite.
Expand Down
68 changes: 1 addition & 67 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Test environments
- GitHub rlib/actions
- R-hub builder
- R-hub2 actions

## R CMD check results
There were no ERRORs or WARNINGs.
Expand All @@ -16,69 +16,3 @@ C++14 is essential for this package.
libs 8.4Mb

This package uses larger libraries.

## httpgd

We are splitting the `httpgd` package up into this package and the `httpgd` package.
This package has all the plotting and rendering code, and the `httpgd` package has the web-service code.

After/if this package is accepted to CRAN, we will submit the new version of the `httpgd` package to CRAN.

# I recently received the following email from CRAN (for httpgd):

> Prof Brian Ripley <[email protected]>
> Wed, Jan 10, 1:51 PM (12 days ago)
> to me, CRAN
>
> Dear maintainer,
>
> Please see the problems shown on
> <https://cran.r-project.org/web/checks/check_results_httpgd.html>.
>
> Please correct before 2024-01-24 to safely retain your package on CRAN.
>
> Do remember to look at the 'Additional issues'.
>
> The CRAN Team
The clang 18 warnings have been addressed in this package.

## Additional issues

> Please always write package names, software names and API (application
> programming interface) names in single quotes in title and description.
> e.g: --> 'C'
> Please note that package names are case sensitive.
'C' has been quoted in the description.

> If there are references describing the methods in your package, please
> add these in the description field of your DESCRIPTION file in the form
> authors (year) <doi:...>
> authors (year) <arXiv:...>
> authors (year, ISBN:...)
> or if those are not available: <https:...>
> with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
> auto-linking. (If you want to add a title as well please put it in
> quotes: "Title")
There are no references for this package.

> Please add \value to .Rd files regarding exported methods and explain
> the functions results in the documentation. Please write about the
> structure of the output (class) and also what the output means. (If a
> function does not return a value, please document that too, e.g.
> \value{No return value, called for side effects} or similar)
> Missing Rd-tags:
> ugd_save_inline.Rd: \value
> ugd_test_pattern.Rd: \value
>
> \dontrun{} should only be used if the example really cannot be executed
> (e.g. because of missing additional software, missing API keys, ...) by
> the user. That's why wrapping examples in \dontrun{} adds the comment
> ("# Not run:") as a warning for the user.
> Please replace \dontrun with \donttest if possible.
These have been addressed.

Thank you!

0 comments on commit ce1486e

Please sign in to comment.