GitHub Action to spellcheck and lint Python code

.github/workflows/ci.yml

@@ -1,6 +1,13 @@
 name: ci
 on: [pull_request, push]
 jobs:
+  codespell_and_ruff:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - run: pip install --user codespell[toml] ruff
+      - run: codespell **/*.py **/*.txt --skip="venv/lib/python3*"
+      - run: ruff check --output-format=github --target-version=py38 .
   ci:
     strategy:
       fail-fast: false

fluidsynth.py

@@ -22,7 +22,10 @@
 ================================================================================
 """
 
-from ctypes import *
+from ctypes import (
+    CDLL, CFUNCTYPE, POINTER, Structure, byref, c_void_p, create_string_buffer, c_char,
+    c_char_p, c_double, c_float, c_int, c_short, c_uint
+)
 from ctypes.util import find_library
 import os
 
@@ -711,7 +714,7 @@ def start(self, driver=None, device=None, midi_driver=None, midi_router=None):
             new_fluid_cmd_handler(self.synth, self.router)
         else:
             fluid_synth_set_midi_router(self.synth, self.router)
-        if midi_router == None: ## Use fluidsynth to create a MIDI event handler
+        if midi_router is None: ## Use fluidsynth to create a MIDI event handler
             self.midi_driver = new_fluid_midi_driver(self.settings, fluid_midi_router_handle_midi_event, self.router)
             self.custom_router_callback = None
         else:                   ## Supply an external MIDI event handler
@@ -880,7 +883,7 @@ def set_chorus_level(self, level):
         if fluid_synth_set_chorus_level is not None:
             return fluid_synth_set_chorus_level(self.synth, level)
         else:
-            return self.set_chorus(leve=level)
+            return self.set_chorus(level=level)
     def set_chorus_speed(self, speed):
         if fluid_synth_set_chorus_speed is not None:
             return fluid_synth_set_chorus_speed(self.synth, speed)
@@ -996,7 +999,7 @@ def get_samples(self, len=1024):
         """
         return fluid_synth_write_s16_stereo(self.synth, len)
     def tuning_dump(self, bank, prog, pitch):
-        return fluid_synth_tuning_dump(self.synth, bank, prog, name.encode(), length(name), pitch)
+        return fluid_synth_tuning_dump(self.synth, bank, prog, name.encode(), len(name), pitch)
 
     def midi_event_get_type(self, event):
         return fluid_midi_event_get_type(event)
@@ -1015,17 +1018,20 @@ def midi_event_get_value(self, event):
 
     def play_midi_file(self, filename):
         self.player = new_fluid_player(self.synth)
-        if self.player == None: return FLUID_FAILED
-        if self.custom_router_callback != None:
+        if self.player is None:
+            return FLUID_FAILED
+        if self.custom_router_callback is not None:
             fluid_player_set_playback_callback(self.player, self.custom_router_callback, self.synth)
         status = fluid_player_add(self.player, filename.encode())
-        if status == FLUID_FAILED: return status
+        if status == FLUID_FAILED:
+            return status
         status = fluid_player_play(self.player)
         return status
 
     def play_midi_stop(self):
         status = fluid_player_stop(self.player)
-        if status == FLUID_FAILED: return status
+        if status == FLUID_FAILED:
+            return status
         status = fluid_player_seek(self.player, 0)
         delete_fluid_player(self.player)
         return status
@@ -1050,14 +1056,14 @@ def __init__(self, time_scale=1000, use_system_timer=True):
     def register_fluidsynth(self, synth):
         response = fluid_sequencer_register_fluidsynth(self.sequencer, synth.synth)
         if response == FLUID_FAILED:
-            raise Error("Registering fluid synth failed")
+            raise Exception("Registering fluid synth failed")
         return response
 
     def register_client(self, name, callback, data=None):
         c_callback = CFUNCTYPE(None, c_uint, c_void_p, c_void_p, c_void_p)(callback)
         response = fluid_sequencer_register_client(self.sequencer, name.encode(), c_callback, data)
         if response == FLUID_FAILED:
-            raise Error("Registering client failed")
+            raise Exception("Registering client failed")
 
         # store in a list to prevent garbage collection
         self.client_callbacks.append(c_callback)
@@ -1097,7 +1103,7 @@ def _create_event(self, source=-1, dest=-1):
     def _schedule_event(self, evt, time, absolute=True):
         response = fluid_sequencer_send_at(self.sequencer, evt, time, absolute)
         if response == FLUID_FAILED:
-            raise Error("Scheduling event failed")
+            raise Exception("Scheduling event failed")
 
     def get_tick(self):
         return fluid_sequencer_get_tick(self.sequencer)

test/sequencerTest.py

@@ -2,7 +2,6 @@
 
 import time
 import fluidsynth
-from ctypes import *
 
 seqduration = 1000