Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During research of issue #157, it was found that the IconPixmap provided by fcitx was empty. https://github.com/fcitx/fcitx5/blob/master/src/modules/notificationitem/notificationitem.cpp#L158
However, this is not a bug in fcitx. In the specification, The pixmap is provided as a fallback.
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/
The icon should be loaded from the IconName before attempting to load the pixmap.