Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RPM lint issue ambiguous python shebang #295

Closed
tim77 opened this issue May 1, 2024 · 2 comments
Closed

[BUG] RPM lint issue ambiguous python shebang #295

tim77 opened this issue May 1, 2024 · 2 comments

Comments

@tim77
Copy link
Contributor

tim77 commented May 1, 2024

Describe the bug
In last v0.9.28 was added airplane-mode indicator script. It have minor issue which RPM linter consider as ERROR.

*** ERROR: ambiguous python shebang in /usr/lib/python3.12/site-packages/nwg_panel/executors/airplane_mode.py: #!/usr/bin/python. Change it to python3 (or python2) explicitly.

Expected behavior
Satisfied linter.

Desktop (please complete the following information):

  • Linux distribution: Fedora
  • Panel version 0.9.28

Additional context
Some minor warnings also could be fixed/improved:

mangling shebang in /usr/lib/python3.12/site-packages/nwg_panel/executors/au.sh from /usr/bin/env bash to #!/usr/bin/bash
mangling shebang in /usr/lib/python3.12/site-packages/nwg_panel/executors/check-notifications from /bin/bash to #!/usr/bin/bash
mangling shebang in /usr/lib/python3.12/site-packages/nwg_panel/executors/github.sh from /bin/bash to #!/usr/bin/bash
*** WARNING: ./usr/share/applications/nwg-panel-config.desktop is executable but has no shebang, removing executable bit
nwg-piotr added a commit that referenced this issue May 1, 2024
@tim77
Copy link
Contributor Author

tim77 commented May 2, 2024

Thanks! New version built successfully without any build issue.

@tim77 tim77 closed this as completed May 2, 2024
@nwg-piotr
Copy link
Owner

Great! Thanks for confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants