Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] After clicking swaync icon on Hyprland, clicking anywhere on the panel brings SwayNC up. #199

Closed
rb-andrade opened this issue Apr 7, 2023 · 4 comments · Fixed by #200

Comments

@rb-andrade
Copy link
Contributor

Describe the bug
After clicking SwayNC icon with preset-2 clicking anywhere on the bar brings SwayNC up.

To Reproduce
Steps to reproduce the behavior:

  1. Click on swaync icon using preset-2 with mouse or touchpad
  2. Click on swaync icon again to close it.
  3. Clicking on any other icons in the nwg-panel with bring swaync up and not the clicked icon.

Expected behavior
Clicking on the other icons should execute the clicked icon command.

Desktop (please complete the following information):

  • Tested both on Arch Linux and Alpine Linux
  • Hyprland v0.23.0beta
  • nwg-panel v0.8.2
@rb-andrade
Copy link
Contributor Author

Clicking using the touchscreen works though.

@nwg-piotr
Copy link
Owner

I haven't investigated it yet, but I think it's a swaync property. I'm not saiyng "issue", since it's Sway Notification Center. The gtk-layer-shell lib behaves differently on Hyprland. E.g. nwg-panel HyprlandTaskbar module must not be placed neither on bottom nor background layer, or the right-click menu lands below windows. If you set a panel layer like this, and add HyprlandTaskbar to it, I silently change the layer to top.

I'll dig a bit more into it soon. Maybe it could be workaround-ed with some config option? If not, we'll have to ask Eric for help.

@nwg-piotr
Copy link
Owner

After some testing: the bug, whatever it is, may lay on my side. I tried to display the swaync icon as a button, and it behaved well. Interesting...

@nwg-piotr nwg-piotr changed the title [BUG] After clicking swaync icon with preset-2 with Hyprland clicking anywhere on the bar brings SwayNC up. [BUG] After clicking swaync icon on Hyprland, clicking anywhere on the panel brings SwayNC up. Apr 10, 2023
@rb-andrade
Copy link
Contributor Author

Tried this and "SwayNC" module behaviour was pretty much fixed, it still doesn't have the same behaviour as in sway, since it is not possible to keep swaync module window open together with other windows.

Same bug mentioned earlier happens with Menu Start button and Clock button, I tried changing them to "on-button-release", but issue was not solved. Changing layer to "overlay" seems to solve the problem and gives me a similar behaviour to sway. Thanks very much for the quick answers and implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants