Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICON not showing #3

Closed
shadowe1ite opened this issue May 12, 2023 · 5 comments · Fixed by #4
Closed

ICON not showing #3

shadowe1ite opened this issue May 12, 2023 · 5 comments · Fixed by #4

Comments

@shadowe1ite
Copy link

shadowe1ite commented May 12, 2023

The nwg-dock is not displaying the application icons for IDA-Free , virtualbox and Burp Suite. However, the icons do appear in nwg-draw and rofi

application name == IDA

nwg-dock : no icon

20230512_22h21m05s_grim

nwg-draw :

20230512_22h22m06s_grim

nwg-piotr added a commit that referenced this issue May 12, 2023
@nwg-piotr
Copy link
Owner

nwg-piotr commented May 12, 2023

I only checked with VirtualBox.

The culprit is the application itself, specifically the client class name. The .desktop file name should be <client_class_name>.desktop. Meanwhile the class name is VirtualBox Manager, while the desktop file name is virtualbox.desktop.

I added a workaround for this certain case (space-separated name, in addition to existent hyphen-separated name), but this for sure won't resolve every single similar issue that may occur.

image

@nwg-piotr
Copy link
Owner

nwg-piotr commented May 12, 2023

Please re-open if the issue persists for some app. I'll need some more info, if so.

@shadowe1ite
Copy link
Author

shadowe1ite commented May 14, 2023

@nwg-piotr please reopen this issue. After updating to nwg-dock-hyprland version 0.1.2, some app icons are not showing, such as burpsuite and ghidra. This was working in the previous version, nwg-dock-hyprland version 0.1.1.

vertualbox and ida icons are working now.

nwg-dock-hyprland version 0.1.1:

20230514_11h41m35s_grim

nwg-dock-hyprland version 0.1.1: no icons

20230514_11h46m31s_grim

@nwg-piotr
Copy link
Owner

nwg-piotr commented May 14, 2023

We will never cover all the badly coded or packaged apps. The only thing the dock knows is the client class, returned by Hyprland:

"class": "burp-StartBurp"

Now we seek an icon or a .desktop file named like this. But they are called 'burpsuite' and 'burpsuite.desktop'. This may be fixed for you on 2 levels, both beside my range:

  1. make Hyprland return the proper class name (however, the problem may be not Hyprland, but the application itself), or
  2. name the .desktop file after the class name.

(If we make the dock use the 1st match for "burp-", we're back in #5.)

The 1st may only be done by Hyprland developers or the application developer. The 2nd you may do on your machine, by just copying /usr/share/applications/burpsuite.desktop to ~/.local/share/applications/ and renaming it to 'burp-StartBurp.desktop`.

image

@shadowe1ite
Copy link
Author

hmm ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants