Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ndx-MIES extension #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

t-b
Copy link

@t-b t-b commented Jun 5, 2020

No description provided.

@rly
Copy link
Contributor

rly commented Jul 16, 2020

Hi @t-b, thank you for submitting this extension to the NDX Catalog!

Please release your URL on PyPI so that there is an easy way for users to install the extension to get the schema files.

I would also recommend having at least a barebones Python package for use in PyNWB. You already have that under ndx-MIES/src/pynwb/ndx_mies. You can make the classes importable and thus accessible to other developers by adding the following to ndx-MIES/src/pynwb/ndx_mies/__init__.py:

UserCommentString = get_class('UserCommentString', 'ndx-mies')
TestpulseMetadata = get_class('TestpulseMetadata', 'ndx-mies')
GeneratedBy = get_class('GeneratedBy', 'ndx-mies')
TestpulseRawData = get_class('TestpulseRawData', 'ndx-mies')
LabNotebookNumericalValues = get_class('LabNotebookNumericalValues', 'ndx-mies')
LabNotebookNumericalKeys = get_class('LabNotebookNumericalKeys', 'ndx-mies')
LabNotebookTextualValues = get_class('LabNotebookTextualValues', 'ndx-mies')
LabNotebookTextualKeys = get_class('LabNotebookTextualKeys', 'ndx-mies')
StimulusSetWaveform = get_class('StimulusSetWaveform', 'ndx-mies')
StimulusSetWavebuilderParameter = get_class('StimulusSetWavebuilderParameter', 'ndx-mies')
StimulusSetWavebuilderParameterText = get_class('StimulusSetWavebuilderParameterText', 'ndx-mies')
StimulusSetWavebuilderSegmentTypes = get_class('StimulusSetWavebuilderSegmentTypes', 'ndx-mies')
StimulusSetReferencedWaveform = get_class('StimulusSetReferencedWaveform', 'ndx-mies')
UserComment = get_class('UserComment', 'ndx-mies')
UserCommentDevice = get_class('UserCommentDevice', 'ndx-mies')
Testpulse = get_class('Testpulse', 'ndx-mies')
TestpulseDevice = get_class('TestpulseDevice', 'ndx-mies')
LabNotebook = get_class('LabNotebook', 'ndx-mies')
StimulusSets = get_class('StimulusSets', 'ndx-mies')
StimulusSetReferenced = get_class('StimulusSetReferenced', 'ndx-mies')
StimulusSetReferencedFolder = get_class('StimulusSetReferencedFolder', 'ndx-mies')
LabNotebookDevice = get_class('LabNotebookDevice', 'ndx-mies')
MIESMetaData = get_class('MIESMetaData', ndx-mies')

@t-b
Copy link
Author

t-b commented Oct 14, 2020

@rly As mentioned in NeurodataWithoutBorders/pynwb#1299 get_class fails to work with the StimulusSetReferencedFolder group.

I'll try to find time to upload the package to pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants