-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running this example freezes my pc #1
Comments
Tried with most recent driver, and still the same issue |
Oh gosh, that's not good! I know I've seen an issue with this sample when you toggle vsync on a system that has both an integrated and a discrete GPU (and it looks like this may be related, since the i7-8700K has integrated graphics), but I've never seen it freeze the entire screen yet. I'll hopefully be looking into this next week or so. Thank you! |
…the bug where on Optimus devices, resizing the window with vsync enabled would cause the image displayed to freeze, while the application would continue to render internally, and hopefully fixes issue #1 as well. To do this, we reworked how the sample manages the swapchain and blitting to the swapchain to be based on how the `vk_devide_generated_cmds` sample works. Here's a brief high-level overview of the changes this entailed: - Instead of its own window, Sample now inherits from `AppWindowProfilerVK`. - The sample no longer draws Dear ImGui data to the swapchain. Instead, it draws it to an intermediate texture, then blits it to the swapchain. - In particular, this means that framebuffers including swapchain images have been removed. (I wonder if this was the cause of the swapchain bug originally). - Introduced an additional intermediate image to which the application draws the GUI. Moving an MSAA image to the swapchain now looks like MSAA _SRGB -> 1spp _SRGB -> 1spp no color space -> swapchain. - Make sure to re-initialize Dear ImGui's pipelines when the application's pipelines are recreated - Use two or three command buffers per frame instead of just 1; I think this can probably be reduced back down to one or two per frame, but I'm waiting to see if this fixes issue #1 before doing so. - Use the NVVK_CHECK macro instead of VkResult result = ...; assert(result == VK_SUCCESS). - Use NVVK's accesses -> stages mapping to reduce the number of arguments required to pass to transitionTo from 4 to 3. - Move some Dear ImGui logic into Sample::DoGUI - Remove VK_USE_PLATFORM_WIN32_KHR declarations, since these are handled by shared_sources' CMake script.
Hi NotStirred, I've just pushed a large update to this sample that seems to fix some of the swapchain freezing issues we were seeing previously internally (see commit 5ec463c for many more details - my best guess is that the sample was creating framebuffers to draw the GUI directly to the swapchain's images, but this was not being updated correctly when the window resized). When you get the chance, could you try it out (after saving your work), and see if this fixes the freezing issue you're seeing here? Thanks! |
Unfortunately I no longer have the operating system I was running then, but I after testing, I got a similar "crash" though was able to recover somehow.
|
OK, interesting! It should definitely be possible to debug this. Are you able to get any information about the stack when it segfaults when running it inside e.g. |
I don't think what I'm currently experiencing is the same issue as I was getting before, as it now only happens with linkedlist sorting. |
Hmm, that continues to be interesting! What do the errors look like when using linkedlist sorting - and are there any signs in the debugger that anything strange is going on? (I have a suspicion of what it might be, but I'm not sure yet.) |
Hi NotStirred, I've just added some pipeline barriers that were missing from all of the draw/clear functions; hopefully this fixes the problem that you're seeing (and please let me know if it does)! I should also be double-checking this on Ubuntu 18.04 LTS at the end of the week. |
thankyou |
Entire screen freezes, both monitors. Audio still plays, but there is nothing I can do except pull the plug.
It happens when I press some of the UI buttons, such as changing the type of OIT, and something else, but I'm not running it again to check
Specs: i7-8700K
8gb ddr4 ram
gtx 760ti - driver 442.59
The text was updated successfully, but these errors were encountered: