Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note compatibility issue with set -e #866

Merged
merged 1 commit into from
Oct 9, 2015
Merged

Note compatibility issue with set -e #866

merged 1 commit into from
Oct 9, 2015

Conversation

jfirebaugh
Copy link
Contributor

See discussion in #865.

@ljharb
Copy link
Member

ljharb commented Oct 9, 2015

Thanks, good idea! Should this include pipefail as well?

@jfirebaugh
Copy link
Contributor Author

Should it? I'm 👍 on adding it if you think it will also cause issues.

@ljharb
Copy link
Member

ljharb commented Oct 9, 2015

hmm - actually, can you test it out? If nvm doesn't fail with pipefail, just with -e, then I think it's best to leave it out. I can't recall any place where I expect anything that's piped to fail.

@jfirebaugh
Copy link
Contributor Author

Sure -- my test case for #865 passes when I remove -e but keep -o pipefail.

ljharb added a commit that referenced this pull request Oct 9, 2015
@ljharb
Merge pull request #866 from jfirebaugh/patch-1
bc4d14b 
[Docs] Note compatibility issue with `set -e` (#866, #865, #721)
@ljharb ljharb merged commit bc4d14b into nvm-sh:master Oct 9, 2015
@ljharb
Copy link
Member

ljharb commented Oct 9, 2015

Also related to #721

@ljharb ljharb mentioned this pull request Oct 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfirebaugh @ljharb