Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message when sourcing nvm.sh #694

Merged
merged 1 commit into from
Mar 18, 2015
Merged

Fix error message when sourcing nvm.sh #694

merged 1 commit into from
Mar 18, 2015

Conversation

pfac
Copy link
Contributor

@pfac pfac commented Mar 18, 2015

Sourcing nvm.sh in version 0.24.0 results in the following message being output to stderr:

ls: yes: No such file or directory

This is caused by nvm_supports_source_options, which fails (as it should apparently) in my environment. While the failing is expected, the error message doesn't seem so, and I personally find it a bit nagging to always see that message when starting a new shell session.

The fix in this PR is very simple, and it doesn't seem to break any test.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ljharb ljharb self-assigned this Mar 18, 2015
@ljharb
Copy link
Member

ljharb commented Mar 18, 2015

Sounds good to me, thanks!

ljharb added a commit that referenced this pull request Mar 18, 2015
@ljharb ljharb merged commit 3cc5d6a into nvm-sh:master Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants