Prefer tee over > to maximize compatibility #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also provide a test case, ideally one that would fail on |
|
I’ll see what I can do. I have absolutely no knowledge of the test suite you are using. Can you give me a few hints/links to docs? |
|
@ohcibi Sure - it's called urchin. Basically each test is an executable shell file. It seems like the test case you want is a file that does |
|
Awesome, this is great. Can you rebase it on top of master, and I'll merge it asap? |
As mentioned in nvm-sh#615 it is possible to configure `>` to not override existing files by default. `tee` is a standard tool that can be used shell independent.
This tests the absence of the bug from nvm-sh#615
ljharb
added a commit
that referenced
this pull request
Jan 23, 2015
Prefer tee over > to maximize compatibility
ljharb
added a commit
to ljharb/nvm
that referenced
this pull request
Feb 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.