-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some files to be more cross platform #2397
Conversation
3a5735b
to
b7ed9a9
Compare
If this PR is ok, I could update the other one for Windows to allow installation by default (from git) instead of script. I would have to update the Windows CI and the Readme. |
This would close #1643, i think. I don’t like having to do this - the repo shouldn’t suffer just because windows’ filesystem is dumb - but if it will help test real windows support (and if the tests will ensure filenames obey the needed conventions moving forward) then it’s probably worth it. |
rename_test.sh
Outdated
while read -r filename; do | ||
new_filename=$(echo "$filename" | sed -r \ | ||
-e "s/\"/'/g" \ | ||
-e 's/</\[/g' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m concerned about this one - there’s a meaningful difference here. <foo>
is both convention for a replacement in a way [foo]
is not, and also, in command line notation, one means a required argument and the other an optional one.
is there another character that might work that looks visually similar to < >
, or are we limited to ascii?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I dont like much to have to put [] instead of <> for the meaning. I ll check if I can find something that look more similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I found a solution :D
What do you think now ?
04487a7
to
2d66c6f
Compare
I have also added a check in the linting CI to ensure no more tests are added with those kind of filename. |
8dad2ee
to
9849bf4
Compare
Would there be any chance of getting this in a release soon? |
It’ll be in the next release for sure. I’m not certain when that will be. |
Issue: the repository cannot be cloned under Windows system as:
The script
rename_test.sh
fix those problem for the files under test folder as it: