Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh should return 0 on success, currently returns 129 #738

Closed
lexual opened this issue Apr 22, 2015 · 5 comments
Closed

install.sh should return 0 on success, currently returns 129 #738

lexual opened this issue Apr 22, 2015 · 5 comments
Labels
installing node Issues with installing node/io.js versions.

Comments

@lexual
Copy link

lexual commented Apr 22, 2015

install.sh should return 0 on success, currently returns 129

This makes it harder to automate installs with deployment tools.

@ljharb
Copy link
Member

ljharb commented Apr 22, 2015

I believe that's a git exit code - do you have git installed? Which version? It exits zero in all of my tests.

@lexual
Copy link
Author

lexual commented Apr 22, 2015

1.7.9.5

@ljharb
Copy link
Member

ljharb commented Apr 22, 2015

Ah, that's an ancient version - you want 2.2 or later due to security issues in older git versions. Specifically, I believe you're lacking support for the git branch --quiet command.

@ljharb ljharb added the installing node Issues with installing node/io.js versions. label Apr 22, 2015
@lexual
Copy link
Author

lexual commented Apr 22, 2015

Oh, for someone reason I spun up a ubuntu 12.04 instance instead of 14.04.

14.04 seems to have 1.9.x which means install.sh returns 0.

@lexual lexual closed this as completed Apr 22, 2015
@ljharb
Copy link
Member

ljharb commented Apr 22, 2015

Awesome, thanks for confirming!

ljharb added a commit that referenced this issue Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installing node Issues with installing node/io.js versions.
Projects
None yet
Development

No branches or pull requests

2 participants