Rewrite regex pattern literal[a-b]{x,y} to custom kernel in rlike #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Co-authored-by: Gera Shegalov <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
…ries (NVIDIA#10836) Signed-off-by: Jason Lowe <[email protected]>
* Add NVTX ranges to identify Spark stages and tasks Signed-off-by: Jason Lowe <[email protected]> * scalastyle --------- Signed-off-by: Jason Lowe <[email protected]>
nvliyuan
pushed a commit
that referenced
this pull request
May 28, 2024
* A hacky approach for regexpr rewrite Signed-off-by: Haoyang Li <[email protected]> * Use contains instead for that case Signed-off-by: Haoyang Li <[email protected]> * add config to switch Signed-off-by: Haoyang Li <[email protected]> * Rewrite some rlike expression to StartsWith/EndsWith/Contains Signed-off-by: Haoyang Li <[email protected]> * clean up Signed-off-by: Haoyang Li <[email protected]> * Draft code to adapt RegexParser in regex rewrite Signed-off-by: Haoyang Li <[email protected]> * clean up Signed-off-by: Haoyang Li <[email protected]> * Apply suggestions from code review Co-authored-by: Gera Shegalov <[email protected]> * A checkpoint before removing endsWith rewrite Signed-off-by: Haoyang Li <[email protected]> * Remove equalsTo and endsWith Signed-off-by: Haoyang Li <[email protected]> * clean up Signed-off-by: Haoyang Li <[email protected]> * address a comment Signed-off-by: Haoyang Li <[email protected]> * address a comment Signed-off-by: Haoyang Li <[email protected]> * address comments Signed-off-by: Haoyang Li <[email protected]> * fix 2.13 build Signed-off-by: Haoyang Li <[email protected]> * checkpoint before pattern matching => if Signed-off-by: Haoyang Li <[email protected]> * Add prefix range in regex parser rewrite Signed-off-by: Haoyang Li <[email protected]> * Address comments Signed-off-by: Haoyang Li <[email protected]> * wip Signed-off-by: Haoyang Li <[email protected]> * clean up Signed-off-by: Haoyang Li <[email protected]> * change some names Signed-off-by: Haoyang Li <[email protected]> * checkpoint before upmerge Signed-off-by: Haoyang Li <[email protected]> * add tests Signed-off-by: Haoyang Li <[email protected]> * Catch exceptions when trying to examine Iceberg scan for metadata queries (NVIDIA#10836) Signed-off-by: Jason Lowe <[email protected]> * Add NVTX ranges to identify Spark stages and tasks (NVIDIA#10826) * Add NVTX ranges to identify Spark stages and tasks Signed-off-by: Jason Lowe <[email protected]> * scalastyle --------- Signed-off-by: Jason Lowe <[email protected]> --------- Signed-off-by: Haoyang Li <[email protected]> Signed-off-by: Jason Lowe <[email protected]> Co-authored-by: Gera Shegalov <[email protected]> Co-authored-by: Jason Lowe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR in main repo: NVIDIA#10822
Depends on package jni pr: wjxiz1992/spark-rapids-jni#1
This pr uses a custom kernel to rewrite regex patterns like
literal[a-b]{x,y}inliketo get performance gain.For example, pattern
abc[0-9]{2,3}will match dataxxxabc12345, and[\u4e00-\u9fa5]+(match chinese characters) will match dataspark-rapids上海.A quick performance test, 2000000 strings with length from 0 to 2000, about 1/3 strings contains a substring "abcdefghijklmnopqrstuvwxyz" and run 100 queries like
'abcdefghijklmnopqrstuvwxy[0-9]{5}'.