Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNN button styled to match Bootstrap buttons #344

Merged
merged 2 commits into from
Dec 12, 2022
Merged

DNN button styled to match Bootstrap buttons #344

merged 2 commits into from
Dec 12, 2022

Conversation

dnndiva
Copy link
Contributor

@dnndiva dnndiva commented Dec 9, 2022

Related to Issue

Fixes #343

Description

Added styling to DNN buttons to look like the theme bootstrap buttons

How Has This Been Tested?

Added button with the 3 DNN system button classes on my local development environment.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@david-poindexter david-poindexter added the enhancement New feature or request label Dec 12, 2022
@david-poindexter david-poindexter added this to the 3.1.0 milestone Dec 12, 2022
david-poindexter
david-poindexter requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnndiva - just a few minor cleanup items.

src/scss/components/_dnn.scss Outdated
.dnnTertiaryAction {
padding: 6px 6px;
}
.dnnTertiaryAction {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

src/scss/components/_dnn.scss Outdated
/* Old browsers */
color: #fff;
}
a.dnnPrimaryAction:hover {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

src/scss/components/_dnn.scss Outdated
background: color('dnnPrimaryAction');
color: #fff;
}
a.dnnPrimaryAction:active {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

src/scss/components/_dnn.scss Outdated
/* Old browsers */
color: #555;
}
.dnnLogin .LoginTabGroup span:hover {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

src/scss/components/_dnn.scss Outdated
a.dnnTertiaryAction:hover {
background: #f2f2f2;
}
a.dnnTertiaryAction:hover {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

src/scss/components/_dnn.scss Outdated
a.dnnTertiaryAction:active {
background: color('dnnTertiaryAction');
}
a.dnnTertiaryAction:active {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

david-poindexter
david-poindexter approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@david-poindexter david-poindexter merged commit 2e75dde into nvisionative:develop Dec 12, 2022
@dnndiva dnndiva deleted the DNNbuttons branch December 12, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees

@dnndiva dnndiva

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Style DNN system buttons to look like the theme buttons would be nice
2 participants
@dnndiva @david-poindexter