Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: impure formatting, lsp fallback not applied on load #171

Merged
merged 5 commits into from
Oct 26, 2024
Merged

fix: impure formatting, lsp fallback not applied on load #171

merged 5 commits into from
Oct 26, 2024

Conversation

xiaoshihou514
Copy link
Collaborator

@xiaoshihou514 xiaoshihou514 commented Oct 26, 2024 •
edited
Loading

closes #167

@xiaoshihou514
Copy link
Collaborator Author

I decided to keep the LspAttach command because I find other solutions more messy the the status quo.

@xiaoshihou514
Copy link
Collaborator Author

I made the option lsp as default option work on load tho.

@xiaoshihou514 xiaoshihou514 changed the title fix: impure formatting fix: impure formatting, lsp fallback not applied on load Oct 26, 2024
@xiaoshihou514 xiaoshihou514 merged commit f439a46 into nvimdev:main Oct 26, 2024
3 checks passed
@xiaoshihou514 xiaoshihou514 mentioned this pull request Oct 26, 2024
Merged
@xiaoshihou514
Copy link
Collaborator Author

We can also do some fancy stuff, making options literally take effect as user set them by using meta tables.

But setting the table manually (and not in config) is rare... We will see if anyone actually does it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Todo
1 participant
@xiaoshihou514