feat: save unused buffers in buffer pool #536
Conversation
| local buf = api.nvim_create_buf(false, true) | ||
|
|
||
| vim.bo[buf].undolevels = -1 | ||
| vim.bo[buf].bufhidden = 'wipe' |
There was a problem hiding this comment.
This option deletes the buffer after the window is closed. It appears that the problem existed before multi-window support was introduced.
Co-authored-by: Lewis Russell <[email protected]>
| end | ||
| api.nvim_win_close(context_winid, true) | ||
| if bufnr ~= nil and api.nvim_buf_is_valid(bufnr) then | ||
| table.insert(buffer_pool, bufnr) |
There was a problem hiding this comment.
It seems that the only entry point to actually inserting a buffer into the pool is here, so can't we avoid need for the delete_excess_buffers() call by simply not inserting a buffer if the pool is at capacity?
There was a problem hiding this comment.
We can't delete buffers in-place, when the command-line window is open, see #507
There was a problem hiding this comment.
That's not what is being suggested?
There was a problem hiding this comment.
As far as I understand, no. If the pool is at capacity and we don't add a buffer, we'll need to delete one. However, if the command-line window is open, we cannot proceed with the deletion. Regardless, sometimes we have to add the buffer to the pool even if the pool is full. While I could introduce another 'if' branch to handle the case when the pool if full and we are not in command-line mode, I doubt it would enhance performance.
There was a problem hiding this comment.
However, I'm not certain it's a good idea to check all buffers in the pool within the delete_excess_buffers function. We might just delete the last buffers in the list instead. I don't believe the buffers will become invalid without a reason.
There was a problem hiding this comment.
Ah tricky, well the improved implementation should do though!
Closes #533