fix: close leaked contexts periodically #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo1321
force-pushed
the
fix-add-gc
branch
from
9c3ff2d to
9ac4403
Compare
apollo1321
commented
Nov 17, 2024
lua/treesitter-context.lua
Outdated
| @@ -69,6 +69,9 @@ end | |||
|
|
|||
| ---@param winid integer | |||
| local update_single_context = throttle_by_id(function(winid) | |||
| -- Remove leaked contexts firstly. | |||
| require('treesitter-context.render').close_leaked_contexts() | |||
There was a problem hiding this comment.
This function is pretty simple, I'm not sure if it worth creating separate throttler for closing leaked contexts.
apollo1321
force-pushed
the
fix-add-gc
branch
from
9ac4403 to
e9235b3
Compare
lewis6991
reviewed
Nov 17, 2024
| @@ -386,6 +386,34 @@ end | |||
|
|
|||
| local M = {} | |||
|
|
|||
| -- Contexts may sometimes leak due to reasons like the use of 'noautocmd'. | |||
There was a problem hiding this comment.
I'm not sure we should be putting in provisions for handling noautocmd cases. If a bug is caused by noautocmd, then it means it was used incorrectly.
There was a problem hiding this comment.
Possibly. However, I’m not sure how to reproduce this bug. satellite.nvim has similar protection, which might contribute to its reliability.
https://github.com/lewis6991/satellite.nvim/blob/main/lua/satellite/view.lua#L260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this issue: #512 (comment)