Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert multiwindow support #523

Closed
wants to merge 1 commit into from
Closed

Revert multiwindow support #523

wants to merge 1 commit into from

Conversation

lewis6991
Copy link
Member

Too buggy, needs more development.

This reverts commit f1b7285.
This reverts commit e7fdb4c.
This reverts commit 9e36638.
This reverts commit 6cba006.
This reverts commit bf6386d.
This reverts commit 3de5708.
This reverts commit 63374d1.

Too buggy, needs more development.

This reverts commit f1b7285.
This reverts commit e7fdb4c.
This reverts commit 9e36638.
This reverts commit 6cba006.
This reverts commit bf6386d.
This reverts commit 3de5708.
This reverts commit 63374d1.
@apollo1321
Copy link
Contributor

Do you have any specific suggestions? Linking the lifespan of two windows in neovim seems to be quite challenging. The only potential way I see to minimize bugs for users not using multiwindow is to maintain the context in a single variable, as was previously done. However, I'm unsure how to bypass the bug-fixing phase when the multiwindow is enabled (maybe writing stress tests for different scenarios?)

@lewis6991
Copy link
Member Author

https://github.com/lewis6991/satellite.nvim manages multi window pretty well. Never had an issue with it. Maybe you can take a look at that.

@apollo1321
Copy link
Contributor

apollo1321 commented Nov 15, 2024

Okay, I think I know how to fix two existing bugs (#522 and #512 (comment)). Will you give me time until the end of the weekend to fix them? Is there anything else you would like to fix besides the two existing problems?

@lewis6991
Copy link
Member Author

I'm seeing issues my side too. Not sure if they are the same issues, but I've not got bandwidth to debug them.

@lewis6991
Copy link
Member Author

I can wait a week for you to apply some fixes and see if that addresses the issues. Would that be ok or shall I revert now?

@apollo1321
Copy link
Contributor

Sounds great, thanks. I'm already fixing it now, I'll bring the PR soon.

@lewis6991
Copy link
Member Author

Things feel more stable now. Closing.

@lewis6991 lewis6991 closed this Dec 20, 2024
@lewis6991 lewis6991 deleted the revert/multiwindow branch December 20, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants