Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: on_attach() return false to disable attaching #521

Merged
merged 1 commit into from
Nov 9, 2024
Merged

fix: on_attach() return false to disable attaching #521

merged 1 commit into from
Nov 9, 2024

Conversation

antoinemadec
Copy link
Contributor

@antoinemadec antoinemadec commented Nov 9, 2024 •
edited
Loading

goal

Fix #520

how it was tested

  1. made sure minimal testcase in Context not showing #283 still works (see 2182556)
  2. made sure on_attach() return false does not display context (see minimal testcase in on_attach() return false does not disable attach #520 )
  3. made sure on_attach() return true display context (see minimal testcase in on_attach() return false does not disable attach #520 )

@lewis6991 lewis6991 merged commit 158377d into nvim-treesitter:master Nov 9, 2024
2 checks passed
@apollo1321 apollo1321 mentioned this pull request Nov 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

on_attach() return false does not disable attach
2 participants
@antoinemadec @lewis6991