Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

Add CI #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/luacheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Linting and style checking

on: [push, pull_request]

jobs:
luacheck:
name: Luacheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1

- name: Prepare
run: |
sudo apt-get update
sudo add-apt-repository universe
sudo apt install luarocks -y
sudo luarocks install luacheck

- name: Run Luacheck
run: sudo ./scripts/style-check.sh
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.luacheckcache
17 changes: 17 additions & 0 deletions .luacheckrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
-- Rerun tests only if their modification time changed.
cache = true

-- Glorious list of warnings: https://luacheck.readthedocs.io/en/stable/warnings.html
ignore = {
"212", -- Unused argument, In the case of callback function, _arg_name is easier to understand than _, so this option is set to off.
"411", -- Redefining a local variable.
"412", -- Redefining an argument.
"422", -- Shadowing an argument
"431", -- Shadowing a variable
"122" -- Indirectly setting a readonly global
}

-- Global objects defined by the C code
read_globals = {
"vim",
}
3 changes: 3 additions & 0 deletions scripts/style-check.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env bash

luacheck `find -name "*.lua"` --codes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can write this as, and if you need to ignore files, you can set those in the config file as https://github.com/nvim-treesitter/nvim-treesitter/blob/dedd74ebdbb8a921d95e3c670be9684d9f655c34/.luacheckrc#L5-L7, also you can add the --codes option in the config file https://github.com/nvim-treesitter/nvim-treesitter/blob/dedd74ebdbb8a921d95e3c670be9684d9f655c34/.luacheckrc#L3

Suggested change
luacheck `find -name "*.lua"` --codes
luacheck .