-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed icon of vue #266
Conversation
Try updading your font instead, this icon has been recently changed to more accurate one. |
Let's merge #264 first |
Not sure we want to merge this one, Alex. Vue icon has been very recently updated to one that's reverted here. If we are using proper icons that are only available in recent font versions we will endlessly get requests like this while solution is to update fonts. We will shortly provide compat tag for version 2 icons. That might solve the issue this pr tries to address. Or we should come up with proper policy on how we handle those things. |
@@ -1453,7 +1453,7 @@ local icons_by_file_extension = { | |||
name = "Vim", | |||
}, | |||
["vue"] = { | |||
icon = "", | |||
icon = "﵂", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the vue icon on master is the correct v3 icon.
The tag should be enough. I have Hack Nerd Font Mono set as my browser font, so I can quickly see in the PR whether the icon is a valid (v3) icon. |
We could maintain a v2 branch rather than a tag, for reverting v3->v2 icons. That's a lot of work and the branches will completely diverge. |
Optimistically closing: @jfbeatit can you please update your font to v3 and test again. We'll reopen if that doesn't work. |
Fix reason: I use the font
SauceCodePro Nerd Font Mono
, after i update this plugin to the latest version, the vue icon can not display anymore.