fix: offset_encoding is required now in make_position_params
#3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockyzhang24
force-pushed
the
fix-encoding
branch
3 times, most recently
from
49478e8
to
141c8f7
Compare
Adapt to the upstream change neovim/neovim@629483e
rockyzhang24
force-pushed
the
fix-encoding
branch
from
141c8f7
to
ecd4fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to the upstream change neovim/neovim@629483e to get rid of the warning message "warning: offset_encoding is required, using the offset_encoding from the first client".
Since the commit neovim/neovim@2dcbfe7,
paramsinbuf_requestcan accept a function that takes the client as a parameter. So instead of sending the same params to all servers, the params with correct offset_encoding will send to each single server.