feat: quickfixhistory picker #1878
Conversation
Thats deeper than i've ever looked into the qf list, so i can't answer these questions right now.
I get what you mean. Its still hard to "greenlight" the one over the other new builtin. I wanna think it over one night. Maybe we have a couple of "spots" open for some more "exotic" new builtins with the removal of |
|
Thanks for the review :)
Yeah no worries, I understand. |
|
Okay its cool, lets do it and its also not a big harm. I'll rebase, add the docs, test again and then merge. Thanks for the PR :) |
Conni2461
force-pushed
the
feat/quickfixhistory
branch
from
b93038d to
338b860
Compare
DON'T EXPECT THIS TO BE UPSTREAMED due to: * nvim-telescope#1228 * https://github.com/nvim-telescope/telescope.nvim/blob/master/CONTRIBUTING.md THIS IS MY PERSONAL changes. port original patch for quickfixhistory picker while considering file name changes etc. * 8d1841b ("feat: quickfixhistory picker (nvim-telescope#1878)", 2022-05-04) * 0621c1c ("break: prefix internal files and add deprecation messages (nvim-telescope#2032)", 2022-07-01) Related: * nvim-telescope#1739 * nvim-telescope#1742 * https://github.com/cgsheeh/telescope.nvim (forked repo) TODO: make this external https://github.com/nvim-telescope/telescope.nvim/blob/master/developers.md Signed-off-by: Osamu Aoki <[email protected]>
Closes #1877
Quick showcase for accessibility of PR
:chistory)quickfixhistory(in lack of better name, in mood to make quick tele PR)qfhistory.mp4
I'm aware that we are not necessarily interested in builtins, but I think this one would make a rare exception since it deeply relates to
(n)vimbuiltin features made more accessible via telescope.@Conni2461 it seems to work well, but I unfortunately underutilize the qflist. The qflist generally is weird (there is
ids for more than 10 qflists? But in practice only 10 lists keep the full history? But only tried creating more than 10 lists once, maybe I made a mistake/overlooked something), maybe there is also edge cases I haven't yet covered.Once I have your sign off, I'll add docs and related things.