Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove code actions #1866

Merged
merged 1 commit into from
Apr 25, 2022
Merged

chore: remove code actions #1866

merged 1 commit into from
Apr 25, 2022
+28 −263

Conversation

Conni2461
Copy link
Member

@Conni2461 Conni2461 commented Apr 21, 2022 •
edited
Loading

i still need to write a changelog entry

@Conni2461 Conni2461 force-pushed the chore/remove_code_actions branch 2 times, most recently from fc41a92 to 6cd4681 Compare April 21, 2022 19:18
This was referenced Apr 21, 2022
Closed
Open
@Conni2461 Conni2461 force-pushed the chore/remove_code_actions branch from 6cd4681 to da5e074 Compare April 25, 2022 20:45
@Conni2461 Conni2461 force-pushed the chore/remove_code_actions branch from da5e074 to 29723f4 Compare April 25, 2022 20:47
@Conni2461 Conni2461 merged commit e7e9046 into nvim-telescope:master Apr 25, 2022
@Conni2461 Conni2461 deleted the chore/remove_code_actions branch April 25, 2022 20:52
This was referenced Apr 25, 2022
Closed
Closed
@schmidma schmidma mentioned this pull request Apr 26, 2022
Merged
@dnjmn dnjmn mentioned this pull request May 1, 2022
Closed
@iwfan iwfan mentioned this pull request May 5, 2022
Closed
rafamadriz added a commit to rafamadriz/gitsigns.nvim that referenced this pull request May 10, 2022
@rafamadriz
doc: telescope no longer supports lsp_code_actions
b9f4141 
Telescope removed support for `code_actions`.
See: `help telescope.changelog-1866`

Ref: nvim-telescope/telescope.nvim#1866
@rafamadriz rafamadriz mentioned this pull request May 10, 2022
Merged
1 task
chenxiaolong added a commit to chenxiaolong/dotfiles that referenced this pull request May 11, 2022
@chenxiaolong
nvim: telescope: Use builtin vim.lsp.buf.code_action
5b1d6a7 
nvim-telescope/telescope.nvim#1866

Signed-off-by: Andrew Gunnerson <[email protected]>
lewis6991 added a commit to lewis6991/gitsigns.nvim that referenced this pull request May 12, 2022
@rafamadriz @lewis6991
doc: telescope no longer supports lsp_code_actions
ffd06e3 
Telescope removed support for `code_actions`.
See: `help telescope.changelog-1866`

Ref: nvim-telescope/telescope.nvim#1866

Co-authored-by: Lewis Russell <[email protected]>
mfrw added a commit to mfrw/dotfiles that referenced this pull request May 19, 2022
@mfrw
vimrc: switch to vim.lsp.buf.code_action() instead of Telescope
ba4ba31 
Reference: nvim-telescope/telescope.nvim#1866

Signed-off-by: Muhammad Falak R Wani <[email protected]>
ck3d added a commit to ck3d/ck3d-nvim-configs that referenced this pull request May 21, 2022
@ck3d
telescope: Fix code actions
1059c14 
reason
nvim-telescope/telescope.nvim#1866
huiwei-menory added a commit to huiwei-menory/neovim-config that referenced this pull request May 21, 2022
@huiwei-menory
fix: 使用 lsp 自带 code actions
0849f16 
nvim-telescope 已移除 code actions，nvim-telescope/telescope.nvim#1866
huiwei-menory added a commit to huiwei-menory/neovim-config that referenced this pull request May 21, 2022
@huiwei-menory
fix: 使用 lsp 自带 code actions
b9326e5 
reason: nvim-telescope/telescope.nvim#1866
@9999years
Copy link

Why were these removed? I really liked this feature!

@Conni2461
Copy link
Member Author

I repeat the reasoning once more (after that i lock this PR). People can also find the reasoning here: #1470 (comment) (like with all breaking changes) and under :help telescope.changelog-1866

vim.lsp.buf.code_action() is the way to go to get code actions from now on. Plugins should not decide to try and reimplement code_actions anymore. Neovim has a perfectly working solution (with more features and less bug then we ever had) and you can switch the underlying UI with whatever you want. We, telescope, offer such a solution https://github.com/nvim-telescope/telescope-ui-select.nvim or there is https://github.com/stevearc/dressing.nvim

You can have fuzzy finding if you set telescope as ui for vim.ui.select. The idea behind that is that people can just feed data into that function and the user can decide the underlying ui to be telescope, fzf, ... So all these plugins don't have to implement the same set of functions that feed the data into these engines. This only happens at one place.

So i suggest using https://github.com/nvim-telescope/telescope-ui-select.nvim to get code_actions back as they were before. I made sure that the displaying mimics the builtin version before removing those builtins. I only forget to put in a proper removal message on calling :Telescope lsp_code_actions that was my bad and i apologize for the inconvenience

@nvim-telescope nvim-telescope locked as too heated and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Conni2461 @9999years