-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat: luarocks support" #90
Conversation
This reverts commit 3fca776.
Hey 👋 It's failing because the release-please workflow needs a github token. You can follow this guide to generate a token and add it to this repo's secrets, it should fix the error (note that the guide names it |
@mrcjkb what about
|
🤔 I suppose the Edit: Yep, the |
I will revert it so far |
Just did this recently so copied what I did (I was using semantic-release in other repos) and then added a @sergii4 since you're maintainer of this repo, if you'd prefer a different approach, feel free to alter. The secret will be available for you to use anyway |
@rcarriga not sure if I have any option since I don't have access to the |
Sorry I mean you can edit the workflow if you'd like, the secret If you don't have any particular opinion on it, you can also just merge. I don't think there's any meaningful difference between semantic-release and release-please |
Also looks like the tests are failing which will block releases with the current setup FYI |
Reverts #88
Failed run.
@mrcjkb could please take a look?