Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dev.path & dev = true #28

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

benlubas
Copy link
Contributor

@benlubas benlubas commented Jul 27, 2024

I'm pretty sure that this works. but rocks-dev.nvim doesn't seem to work if it's installed with rocks-git.nvim so I don't have a good way to test until it's published I don't think.

Is there a way to further isolate the tests? neovim globals seem to persist between tests so I had to explicitly unset it after each test for it to work.


  • Pull request title has the appropriate conventional commit prefix.
  • Tested
    • Tests have been added.
    • Tested manually. I am unable to test manually, the plugin doesn't seem to work when installed from git.
  • Updated documentation.

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@benlubas benlubas force-pushed the push-ltzwlrlsploz branch from efa7866 to 2ef2022 Compare July 27, 2024 23:07
@benlubas benlubas marked this pull request as ready for review July 27, 2024 23:07
Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🙏 🚀

Looks mostly good to me. Just some minor suggestions.

@mrcjkb
Copy link
Member

mrcjkb commented Jul 28, 2024

Is there a way to further isolate the tests? neovim globals seem to persist between tests so I had to explicitly unset it after each test for it to work.

I think this is only possible if you use GNU parallel or fd -x to run each test file in parallel. But then you need to make sure the environments are isolated.

@mrcjkb
Copy link
Member

mrcjkb commented Jul 28, 2024

Tested manually. I am unable to test manually, the plugin doesn't seem to work when installed from git

Strange 🤔
Are you using rocks-git.nvim?
Anyways, the automated test looks good to me.

Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more request (sorry):

Could you please squash the commits?
Otherwise release-please will pick up your fix commit as a bug fix in the changelog.
I don't know why, but squashing with the GitHub UI doesn't seem to work so well with release-please.

@benlubas benlubas force-pushed the push-ltzwlrlsploz branch from 874114d to d4050d7 Compare July 28, 2024 01:30
@benlubas benlubas force-pushed the push-ltzwlrlsploz branch from d4050d7 to fd78ec2 Compare July 28, 2024 01:33
@benlubas
Copy link
Contributor Author

Done, also added a note about dir having priority over dev = true

@mrcjkb mrcjkb merged commit 4c922b8 into nvim-neorocks:main Jul 28, 2024
3 checks passed
@benlubas benlubas deleted the push-ltzwlrlsploz branch July 28, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants