-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dev.path & dev = true #28
Conversation
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
efa7866
to
2ef2022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution 🙏 🚀
Looks mostly good to me. Just some minor suggestions.
I think this is only possible if you use GNU |
Strange 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more request (sorry):
Could you please squash the commits?
Otherwise release-please will pick up your fix
commit as a bug fix in the changelog.
I don't know why, but squashing with the GitHub UI doesn't seem to work so well with release-please.
874114d
to
d4050d7
Compare
d4050d7
to
fd78ec2
Compare
Done, also added a note about |
I'm pretty sure that this works. but
rocks-dev.nvim
doesn't seem to work if it's installed withrocks-git.nvim
so I don't have a good way to test until it's published I don't think.Is there a way to further isolate the tests? neovim globals seem to persist between tests so I had to explicitly unset it after each test for it to work.