fix: use nio.create to remove rock synchronously within pcall #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the 2nd error in #16 I wrappedoperations.remove
innio.create
. My thinking is the error thrown for calling async in a sync context is related topcall
being a sync method. By usingnio.create
rock removal is handled synchronously withinpcall
.Since this occurs in a larger async context created by
api.query_installed_rocks
the overall process should still be async.Edit: I did more testing locally and have found this does not fix the issue :( I will keep looking at it though!