Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use nio.create to remove rock synchronously within pcall #19

Closed
wants to merge 1 commit into from

Conversation

bottd
Copy link
Contributor

@bottd bottd commented Jun 7, 2024

To resolve the 2nd error in #16 I wrapped operations.remove in nio.create. My thinking is the error thrown for calling async in a sync context is related to pcall being a sync method. By using nio.create rock removal is handled synchronously within pcall.

Since this occurs in a larger async context created by api.query_installed_rocks the overall process should still be async.

Edit: I did more testing locally and have found this does not fix the issue :( I will keep looking at it though!

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@bottd bottd closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant