fix: completion for TODO items #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the "(" as a trigger character, prevent ( from spawning a ) with
the updated regex and updated the completion table.
I'm not super familiar with the new syntax yet.. or the syntax in
general; so I'll probably end up reading up on the documentation to see
what other completions can be disregarded and what completions should be
added. But I'll do that in a future pull request.
HendrikPetertje
requested review from
vhyrro,
mrossinek and
danymat
as code owners
HendrikPetertje
commented
Jan 12, 2023
| @@ -86,7 +86,7 @@ module.public = { | |||
| end | |||
|
|
|||
| function module.private.source:get_trigger_characters() | |||
| return { "@", "-", "[", " ", "." } | |||
| return { "@", "-", "[", "(", " ", "." } | |||
There was a problem hiding this comment.
Before I would recommend merging this:
Can i safely remove [ as a trigger character for completion start?
There was a problem hiding this comment.
yeah, there are no other constructs where [ is required as a trigger character in norg. You can safely remove it imo :)
|
Thanks a bunch for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the "(" as a trigger character, prevent ( from spawning a ) with the updated regex and updated the completion table.
I'm not super familiar with the new syntax yet.. or the syntax in general; so I'll probably end up reading up on the documentation to see what other completions can be disregarded and what completions should be added. But I'll do that in a future pull request.