feat(intergrations.otter): update to use otter 2.0 #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back to draft as there is a bug causing inconsistent completions. |
|
Happy to see otter being improved. If you could explain the bug I can also give it a look. |
|
Perhaps you will have better luck finding a consistent reproduction. Though as jmbuhr mentions in that thread, it might be an issue with nvim or pyright. |
|
@vhyrro I'm okay with merging this. I can't reproduce it anymore |
|
Hah sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otter.nvim got a pretty large update.
TL;DR: it's a language server now, so no need to custom keybinds (normal LSP keybinds are used)