-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More calendar UI mappings #1483
Conversation
I also didn't add all the mappings to the help thing yet. I can do that tomorrow |
@simonhughxyz feedback/testing would be appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this, left some comments.
issue: I've noticed that |
810942a
to
16fe910
Compare
Have updated with the latest from our discussion on discord and feedback above. TL;DR:
This also adds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of code looks great now, just some finishing touches.
16fe910
to
f7fa142
Compare
Is there a reason we can't set our own bindings? I am going to get into neorg dev soon i want to help build this. |
closes #1340
Notably, the suggested
g
in that is nowd
and the suggestedt/T
is nowg/G
b/ct
is already taken.