Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More calendar UI mappings #1483

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

benlubas
Copy link
Contributor

closes #1340

Notably, the suggested g in that is now d and the suggested t/T is now g/G b/c t is already taken.

benlubas added 2 commits June 25, 2024 16:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@benlubas
Copy link
Contributor Author

I also didn't add all the mappings to the help thing yet. I can do that tomorrow

@benlubas
Copy link
Contributor Author

@simonhughxyz feedback/testing would be appreciated!

Copy link
Member

@vhyrro vhyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this, left some comments.

lua/neorg/modules/core/ui/calendar/views/monthly.lua Outdated Show resolved Hide resolved
lua/neorg/modules/core/ui/calendar/views/monthly.lua Outdated Show resolved Hide resolved
lua/neorg/modules/core/ui/calendar/views/monthly.lua Outdated Show resolved Hide resolved
lua/neorg/modules/core/ui/calendar/views/monthly.lua Outdated Show resolved Hide resolved
lua/neorg/modules/core/ui/calendar/views/monthly.lua Outdated Show resolved Hide resolved
@vhyrro
Copy link
Member

vhyrro commented Jun 26, 2024

suggestion(blocking): I've also found that the new help is too large for the window. Perhaps we should up the default size of the window so that everything comfortably fits :)

image

@vhyrro
Copy link
Member

vhyrro commented Jun 26, 2024

issue: I've noticed that e skips the current month and goes straight to the end of the next month. Another thing to fix :)

@benlubas benlubas force-pushed the push-xzonypwklssm branch from 810942a to 16fe910 Compare June 26, 2024 21:00
@benlubas
Copy link
Contributor Author

Have updated with the latest from our discussion on discord and feedback above. TL;DR:

  • <count>g instead of g<count>
    • same for d
  • g/G deal with month days in the monthly view
  • g -> 1st of the month
  • G -> last of the month
  • c/C is completely gone b/c it's out of place in the monthly view

This also adds winfixbuf for the help windows and the calendar buffer itself.

Copy link
Member

@vhyrro vhyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of code looks great now, just some finishing touches.

lua/neorg/modules/core/ui/calendar/views/monthly.lua Outdated Show resolved Hide resolved
lua/neorg/modules/core/ui/calendar/views/monthly.lua Outdated Show resolved Hide resolved
@benlubas benlubas force-pushed the push-xzonypwklssm branch from 16fe910 to f7fa142 Compare June 27, 2024 13:17
@vhyrro vhyrro merged commit a5c2624 into nvim-neorg:main Jun 27, 2024
6 checks passed
@benlubas benlubas deleted the push-xzonypwklssm branch June 27, 2024 16:24
@turkishfilms
Copy link

Is there a reason we can't set our own bindings? I am going to get into neorg dev soon i want to help build this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More and better calendar ui mappings
4 participants