fix: supress swap file errors #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhyrro
reviewed
Jun 7, 2024
vhyrro
reviewed
Jun 7, 2024
| @@ -53,13 +53,14 @@ local Path = require("pathlib") | |||
|
|
|||
| local neorg = require("neorg.core") | |||
| local log, modules, utils = neorg.log, neorg.modules, neorg.utils | |||
| local dirman_utils | |||
There was a problem hiding this comment.
If this variable is only used once, then is there a point of creating it here? I'd say YAGNI in this case :p
There was a problem hiding this comment.
I just think it's so much cleaner this way, and I just do that everywhere.
+ smaller diffs in the future if you are to add something that uses dirman_utils and want to pull it into a variable then.
You've also already merged code that does this :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1451 caught an error caused by swap files and produced an error message that heavily suggested the error was caused by swap and could be ignored when that was never confirmed. Some concern was raised about this approach, and an additional cases of the same bug was found...
So this PR checks the error message (via pattern match) to confirm that a swap error was the cause of
vim.cmd.editfailing, and in these cases eats the error message. It's okay (and I'd say preferred) to eat this error b/c a lengthy swap message will pop up on screen for the user, so users will not be confused about what's happening.In case the error is not caused be swap, it's now re-raised with the exact error message.
#1451 handled the edit call in
:Neorg index, this pr additionally handles a call in the hop module when following a link that's opened in nvim.