Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TS autocomplete #1412

Merged
merged 6 commits into from
May 23, 2024
Merged

feat: TS autocomplete #1412

merged 6 commits into from
May 23, 2024

Conversation

benlubas
Copy link
Contributor

@benlubas benlubas commented Apr 29, 2024

Uses Treesitter to find autocompletion suggestions. Has a few impacts:

  • we'll no longer incorrectly link to norg in a verbatim or like a code block or something
  • now links to line targets like inline <target> with {#|} completions
  • {#|} completions will correctly suggest footers and other targets that it wouldn't before

I just pulled the query from core.esupports.hop. We could maybe refactor that out, b/c currently completion requires hop, which is slightly weird. Lmk if I should do that and what helper module you'd like me to use/make.

@benlubas benlubas changed the title feat/ts autocomplete feat: TS autocomplete May 6, 2024
Copy link
Member

@vhyrro vhyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think that the wisest way of handling esupports.hop is to extract the finding logic out into a separate module (e.g. core.links), then having esupports.hop do the actual hopping. Will you want to tackle that in a separate PR?

@benlubas
Copy link
Contributor Author

Blocked on #1428, but this PR is now updated so it can be merged right after #1428

@vhyrro
Copy link
Member

vhyrro commented May 20, 2024

One conflict that needs fixing, you know what to do :p

@benlubas benlubas requested a review from vhyrro May 21, 2024 04:03
@vhyrro vhyrro merged commit 79f6a49 into nvim-neorg:main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants