Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keybinds): add opts arg to remap(_event) #1256

Merged
merged 1 commit into from
Jan 6, 2024
Merged

feat(keybinds): add opts arg to remap(_event) #1256

merged 1 commit into from
Jan 6, 2024

Conversation

aorith
Copy link
Contributor

@aorith aorith commented Dec 30, 2023

For consistency with the map keybind hook. (#1255)

The new opts table has priority over the old one. Feel free to reject the PR if not allowing to override opts is intentional.

@vhyrro
Copy link
Member

vhyrro commented Jan 6, 2024

Code looks good to me! Thanks :)

@vhyrro vhyrro merged commit 27af839 into nvim-neorg:main Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

@mrossinek mrossinek Awaiting requested review from mrossinek

@danymat danymat Awaiting requested review from danymat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aorith @vhyrro