-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tangle): add report_on_empty
option in core.tangle
#1250
Conversation
I sure love github's default commit messages. Either way the conflict should be resolved now properly. Could you double check if this is the case @pysan3? Afterwards we can merge it. |
@vhyrro As you can see, now the ci result is a ❌ due to these errors caused by the PR I mentioned. Are they gonna be my fault now? Should I fix them in this PR? |
Doing some experiments, does the current v1 parser parse relative tags correctly in the first place? I don't think this exports to the correct path (or doesn't do tangling in the first place?). #tangle ../init.lua
@code lua
print("Hello world")
@end Upward relative path does work when specified in the |
The above commit resolves the conflict and uses better mechanism to generate the output filepath without some complicated lua code like counting gmatch. |
Fantastic, thanks a lot for all the work. |
…rg#1250) Co-authored-by: vhyrro <[email protected]>
…rg#1250) Co-authored-by: vhyrro <[email protected]>
Changes
report_on_empty
option.Notes