Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to display total line number in the location component #1334

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thisisrandy
Copy link

Adds total_lines_in_location option to display location as current_line/total_lines:current_col. Two notes:

  1. I modeled location.lua off of fileformat.lua in order to have access to self.options. This may not be the best approach.
  2. This PR is INCOMPLETE. In particular, it doesn't include docs updates. There might reasonably be a test to write, too. Haven't explored that yet. The motivation for the current PR is to see if the maintainers approve of the approach and solicit any comments.

@thisisrandy
Copy link
Author

Addresses #1333

@thisisrandy
Copy link
Author

I'm trying to test locally and running into some issues. What exactly is meant (from CONTRIBUTING.md) by "For running tests you'll have to make sure lualine.nvim, plenary.nvim and nvim-web-devicons are in same directory"? The expected directory tree would be helpful.

I interpretted this as, "copy the contents of the plenary/icons lua and scripts dirs into the same dirs in your lualine dir," and that got me through linting without any errors. However, make test unhelpfully outputs the following and then immediately exits with 0:

nvim --headless --noplugin -u scripts/minimal.vim -c "PlenaryBustedDirectory tests/plenary/ {minimal_init = 'tests/minimal_init.vim', sequential = true}"
Starting...%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant