Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate each section when generating string #63

Merged
merged 6 commits into from
Feb 12, 2021

Conversation

Conni2461
Copy link
Collaborator

@Conni2461 Conni2461 commented Feb 6, 2021

Also:

  • Group directories first
  • update gen_date so it will show %b %d $Y if last modified is not from
    this year
  • Bug fix for symbolic links
  • Show resolved symbolic link, like this:
    a -> b
  • Correctly align user and groups. So should align like this:
  conni    conni     DATE
  root     root      DATE
  asdfasdf asdfasdf  DATE

Also:
- Group directories first
- update gen_date so it will show %b %d $Y if last modified is not from
  this year
- Bug fix for symbolic links
- Show resolved symbolic link, like this:
  a -> b
- Correctly align user and groups. So should align like this:
  conni    conni     DATE
  root     root      DATE
  asdfasdf asdfasdf  DATE
Copy link
Contributor

@kkharji kkharji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Powered by octo.nvim

@pwntester this should be the auto-appended :D

README.md Outdated Show resolved Hide resolved
function Path:write(txt, flag, mode)
assert(flag, [[Path:write_text requires a flag! For example: 'w' or 'a']])

mode = mode or 438
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if for some reason the user provided a bool true? would we still want to default to 438?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone just passes in a boolean i want that his home_dir gets deleted 🤣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use that pattern for mode everywhere so i don't care :)

README.md Outdated Show resolved Hide resolved
lua/plenary/path.lua Show resolved Hide resolved
lua/plenary/scandir.lua Show resolved Hide resolved
Conni2461 and others added 2 commits February 12, 2021 19:08
Co-authored-by: tami5 <[email protected]>
Co-authored-by: tami5 <[email protected]>
README.md Outdated Show resolved Hide resolved
@Conni2461 Conni2461 merged commit 877f799 into nvim-lua:master Feb 12, 2021
@Conni2461 Conni2461 deleted the ls_sections branch February 12, 2021 19:10
@Conni2461
Copy link
Collaborator Author

tj if you ever come here :) i f up the commit message. It should have been fixes for scandir or something like this 😆
I was more worried about the actual description and to include all the changes that i forgot to check the title again 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants