Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test_harness): followup to #459, dont use --clean but rather --noplugin #497

Merged
merged 1 commit into from
May 24, 2023

Conversation

Conni2461
Copy link
Collaborator

otherwise its a breaking change, see
nvim-treesitter/nvim-treesitter#4856

@Conni2461 Conni2461 merged commit 6aeb98d into master May 24, 2023
@Conni2461 Conni2461 deleted the fix/cithings branch May 24, 2023 11:52
@wookayin
Copy link
Contributor

wookayin commented Sep 26, 2023

A consequence of this change is that, by default a non-clean, non-plugin neovim will run: this means that (i) the default init.lua is executed but (ii) no plugins will be loaded. Isn't a weird combination? I feel a breaking change like #459 is needed and all the downstream projects should migrate to the behavior by explicitly specifying init files.

Therefore, if user's init.lua is using plenary.nvim in their normal config (which I think is quite usual), the startup process will crash because plenary won't be available due to suppressed plugin loading, until init.lua is complete and set rtp is executed.

Error detected while processing ~/.config/nvim/init.lua:
E5113: Error while calling lua chunk:
~/.config/nvim/lua/init.lua:XX: module 'plenary.path' 
not found:
        no field package.preload['plenary.path']

@Conni2461
Copy link
Collaborator Author

please open a new issue, then we can have a discussion on how we would solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants