Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move all of popup into plenary #209

Merged
merged 6 commits into from
Aug 11, 2021
Merged

feat: Move all of popup into plenary #209

merged 6 commits into from
Aug 11, 2021

Conversation

tjdevries
Copy link
Member

The plan is that we will deprecate (and then archive) nvim-lua/popup.nvim

There has been some confusion and overlap between the two plugins and this will make things simpler to manage and to keep them in sync. The end goal is still to upstream the work done in (now) plenary.popup.

@l-kershaw here is PR :)

@l-kershaw
Copy link
Collaborator

I think overall I'm pretty happy with moving this over, and the way that you've done it.
I definitely agree that it will be easier to work on improvements to popup since all the dependencies are in one place.

A few quick thoughts:

  • It might be helpful to also move the readme over, so that popups progress can continue to be tracked without cluttering the main readme?
  • The check for matching imports doesn't check for things of the form require("plenary.foobar").cool_function, which is allowed by stylua. I always get confused with regexes, so not sure the best way to check this too 😅

@tjdevries tjdevries merged commit 5e5c87f into master Aug 11, 2021
Conni2461 pushed a commit to Conni2461/plenary.nvim that referenced this pull request Aug 13, 2021
* feat: Move all of popup into plenary

* fixup: Add lint that only certain plenary modules can be required

* fixup: stylua

* fixup: Update test to search for both types of requires

* fixup: Add readme

* fixup: Update readme
@Conni2461 Conni2461 deleted the popup branch August 13, 2021 13:25
Jint-lzxy pushed a commit to ayamir/nvimdots that referenced this pull request Apr 3, 2023
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Apr 3, 2023
boomker pushed a commit to boomker/uvcode-nvim that referenced this pull request Apr 4, 2023
CharlesChiuGit referenced this pull request in CharlesChiuGit/nvimdots.lua Apr 6, 2023
YanTree pushed a commit to YanTree/nvim that referenced this pull request Apr 9, 2023
@shellheim
Copy link

@tjdevries I think you forgot to archive popup? nvim-lua/popup.nvim#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants