feat(profile): add wrapper around LuaJIT profiler #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjdevries
reviewed
Jun 28, 2021
This is a thin wrapper around LuaJIT's `jit.p` with the right "magic" options set. Only configuration right now is `flame=true` to output flamegraph-compatible logs; see https://github.com/jonhoo/inferno to be used with ``` inferno-flamegraph profile.log > flame.svg ``` The SVG file can then be viewed in the browser. This commit includes a vendored version of the latest upstream `jit.p` that fixes a bug with flushing the output file; once LuaJIT/LuaJIT@95140c5 is pulled in, this file can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a thin wrapper around LuaJIT's
jit.pwith the right "magic" options set. Only configuration right now isflame=trueto output flamegraph-compatible logs; see https://github.com/jonhoo/infernoto be used with
The SVG file can then be viewed in the browser.
This commit includes a vendored version of the latest upstream
jit.pthat fixes a bug with flushing the output file; once LuaJIT/LuaJIT@95140c5 is pulled in, this file can be removed.More configuration options are left for a future PR.
Thanks to @leiserfg for showing me how to actually get this working!