feat: add FlutterRename command #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command adds support for `updateImportsOnRename` setting (https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/tool/lsp_spec/README.md#client-workspace-configuration). It is useful when file is renamed after class rename (when enabled `renameFilesWithClasses` setting). It will fallback to `vim.lsp.buf.rename()` if no `dartls` client found. If client is found, file is the same as class name, and class is being renamed, it will request for changes via `workspace/willRenameFiles`. Results of `workspace/willRenameFiles` will be applied after class rename. To test it try to rename class which is in the file with same file name. Before: class renamed, file renamed, usage of class renamed, but imports are not updated. After: class renamed, file renamed, usage and imports are updated.
akinsho
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Just had a quick look, not a super detailed review atm. Looks good generally, just some stylistic comments. Also one somewhat big comment which is mainly I wonder if a lot of this logic isn't already handled by the lsp stuff like calculating which files to update etc. also I wonder if vim.lsp.util.rename can't also be used here
|
will fix #233 |
akinsho
reviewed
Apr 6, 2023
There was a problem hiding this comment.
@sidlatau thanks for factoring out the ui.input calls and the lsp.get_client stuff makes things much cleaner. The remaining stuff I've flagged are almost entirely stylistic. Things like
- Adding type annotations to make the code easier to use with lua ls
- preferring
old->prev,actual->current expand("magic")->vim.fs.(base|dir)name(api.nvim_buf_get_name())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command adds support for
updateImportsOnRenamesetting (https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/tool/lsp_spec/README.md#client-workspace-configuration).It is useful when the file is renamed after a class rename (when enabled
renameFilesWithClassessetting).It will fall back to
vim.lsp.buf.rename()if nodartlsclient is found.If the client is found, the file is the same as the class name, and the class is being renamed, it will request for changes via
workspace/willRenameFiles. Results ofworkspace/willRenameFileswill be applied after the class rename.To test it try to rename the class that is in the file with the same file name.
vim.lsp.buf.rename(): class renamed, file renamed, usage of class renamed, but imports are not updated.FlutterRename: class renamed, file renamed, usage and imports are updated.