-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add project configuration #232
Conversation
79399f1
to
767b0ff
Compare
I want to add more details, about what problem I want to solve with project config: I have a project with two flavors and |
@sidlatau yeah currently the idea was just picking one of the configs on startup but that's somewhat arbitrary since I don't have that use case. It can easily store both configs and then when you run start we can check if you have a project config and show the selection prompt at that stage? would that solve the runtime issue? |
Yes, that may work. I was also thinking about a separate command for setting configuration. But configuration should be set before running |
278868a
to
66acf6f
Compare
Rather than asking at startup, at each run command if there are multiple project configurations as the user which they would like use
66acf6f
to
70be502
Compare
@sidlatau yeah the configuration is IMO similar to a launch.json or something it's something that you can change over time but isn't intended to be some super dynamic thing that needs changing with a command presumably there are standard ways to run your project and those are fairly consistent and not things that are changing super often. |
Could support for |
b13f765
to
be7a714
Compare
reducing flakiness
be7a714
to
cab6a37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality works with my project configuration 👍🏻
I think mentioning in README/docs is missing, and it will be LGTM
One more thing: if the app is already started and I run
Maybe it is possible to check if Flutter is already running before showing the selector? |
Implements #79
cc @sidlatau here's the branch I mentioned.
Currently the workflow is, a user creates an
exrc
file ie. a.nvim.lua
or a.nvimrc
and they add something likeI've only implemented support for the device key atm but the others could be added eventually. The plan won't be to support everything immediately, but just to get a system in place for this PR.