Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix old regression in SetActiveSection. #59

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

jeanplevesque
Copy link
Member

@jeanplevesque jeanplevesque commented Feb 22, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

Using the generic overload of SetActiveSection can sometimes result in the following error even though the correct type parameter is passed.

Can't process navigation because no view is registered with 'Chinook.StackNavigation.INavigableViewModel'. Provide a view type in the NavigationRequest or provide a registration in the constructor.

What is the new behavior?

Using the generic overload of SetActiveSection now properly works in all cases.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

@jeanplevesque jeanplevesque requested a review from a team February 22, 2024 20:22
Copy link

@Lee31416 Lee31416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@jeanplevesque jeanplevesque merged commit 77822d3 into main Feb 22, 2024
4 checks passed
@jeanplevesque jeanplevesque deleted the dev/jpl/fix-set-active-section branch February 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants