Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use uno-check to compile with .net sdk 7.0.102 and make documentation not UWP specific #55

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

lamonfly
Copy link
Contributor

@lamonfly lamonfly commented Dec 5, 2023

GitHub Issue: #

#294905
#295030

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

Apps which compile using .NET SDK 7 encounter build errors when using Chinook.Navigation

What is the new behavior?

Apps which compile using .NET SDK 7.0.102 build correctly

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

Updated StackNavigation-Setup documentation to no longer be UWP specific

.NET SDK 7.0.100 has issues handling dotnet test with coverlet

@lamonfly lamonfly force-pushed the dev/febr/add-uno-check branch 6 times, most recently from 91652f0 to 244ede3 Compare December 6, 2023 15:16
@lamonfly lamonfly marked this pull request as ready for review December 6, 2023 15:26
@lamonfly lamonfly changed the title fix: Use uno-check to compile with .net sdk 7.0.101 and make documentation not UWP specific fix: Use uno-check to compile with .net sdk 7.0.102 and make documentation not UWP specific Dec 6, 2023
@lamonfly lamonfly force-pushed the dev/febr/add-uno-check branch from 244ede3 to 7a32a1a Compare December 6, 2023 15:32
@lamonfly lamonfly force-pushed the dev/febr/add-uno-check branch from 7a32a1a to 4d03d5a Compare December 6, 2023 15:51
@carlh98 carlh98 requested a review from a team December 6, 2023 17:32
@lamonfly lamonfly merged commit 0475a67 into feature/Uno5Update Dec 6, 2023
4 checks passed
@lamonfly lamonfly deleted the dev/febr/add-uno-check branch December 6, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants