forked from rapidsai/cudf
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't unnecessarily retrieve offsets from strings columns for unslice…
…d columns during overflow checking.
- Loading branch information
1 parent
fa3ae36
commit 25d2d11
Showing
1 changed file
with
8 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25d2d11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A sliced column could be sliced by size only which would mean the offset would be 0.
You may want to check
scv.size()==scv.offsets().size()+1
as well asscv.offset() > 0