Skip to content

Commit

Permalink
workload/ycsb: default --read-modify-write-in-txn to false
Browse files Browse the repository at this point in the history
The `read-modify-write-in-txn` flag was added to ycsb in cockroachdb#103117. This
commit changes the default of the flag from true to false. This makes
the default configuration of ycsb more closely mirror the official ycsb
implementation, to avoid confusion when external users run the workload
and compare.

We saw in cockroachdb#103117 and in cockroachdb#107517 that this improves throughput
substantially. We will expect to see the same in roachperf once this
change is merged. After merging the PR, I will add a roachperf annotation.

Epic: None
Release note: None
nvanbenschoten committed Jul 25, 2023
1 parent 451d761 commit a66078e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/workload/ycsb/ycsb.go
Original file line number Diff line number Diff line change
@@ -135,7 +135,7 @@ var ycsbMeta = workload.Meta{
g.flags.IntVar(&g.recordCount, `record-count`, 0, `Key to start workload insertions from. Must be >= insert-start + insert-count. (Default: insert-start + insert-count)`)
g.flags.BoolVar(&g.json, `json`, false, `Use JSONB rather than relational data.`)
g.flags.BoolVar(&g.families, `families`, true, `Place each column in its own column family.`)
g.flags.BoolVar(&g.rmwInTxn, `read-modify-write-in-txn`, true, `Run workload F's read-modify-write operation in an explicit transaction.`)
g.flags.BoolVar(&g.rmwInTxn, `read-modify-write-in-txn`, false, `Run workload F's read-modify-write operation in an explicit transaction.`)
g.flags.BoolVar(&g.sfu, `select-for-update`, true, `Use SELECT FOR UPDATE syntax in read-modify-write operation, if run in an explicit transactions.`)
g.flags.IntVar(&g.splits, `splits`, 0, `Number of splits to perform before starting normal operations.`)
g.flags.StringVar(&g.workload, `workload`, `B`, `Workload type. Choose from A-F.`)

0 comments on commit a66078e

Please sign in to comment.